Skip to content

Conversation

@ISlavinskyi
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Unable to connect to the database. Retrying (1)...

What is the new behavior?

Unable to connect to the database. Message: password authentication failed for user "postgres". Retrying (1)...

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@kamilmysliwiec
Copy link
Member

This message is hidden on purpose to avoid duplicating it between several "retry" messages. It will show up eventually (after the last retry) anyway.

If you think that having it for every error log might be valuable, can we add it under a configuration option? For example, when someone explicitly specifies: verboseRetryLog: true?

@ISlavinskyi
Copy link
Contributor Author

This message is hidden on purpose to avoid duplicating it between several "retry" messages. It will show up eventually (after the last retry) anyway.

If you think that having it for every error log might be valuable, can we add it under a configuration option? For example, when someone explicitly specifies: verboseRetryLog: true?

Yeah, it will be cool feature, which helps in dev mode, where developer can see error message and error code

@kamilmysliwiec
Copy link
Member

Can you add it to your PR then @ISlavinskyi :) ? verboseRetryLog config option to enable verbose messages on each retry.

Also, please, resolve conflicts that popped up after merging another PR.

@ISlavinskyi
Copy link
Contributor Author

Can you add it to your PR then @ISlavinskyi :) ? verboseRetryLog config option to enable verbose messages on each retry.

Also, please, resolve conflicts that popped up after merging another PR.

done :)

@kamilmysliwiec kamilmysliwiec merged commit 6acde56 into nestjs:master May 26, 2020
@kamilmysliwiec
Copy link
Member

Looks great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants