Pull UseNetDaemonAppSettings extension method's ConfigureSerices into its own extension method

[PartemImperium]

The problem

Currently the HostBuilderExtensions.UseNetDaemonAppSettings function both configures the ServiceCollection and adds the Configuration sources that netdaemon uses by default. I would like to use the default/ my own configuration providers and not use the "HostbuilderExtensions.UseNetDaemonAppSettings" function. However because it both configure's the service collection and adds the providers I need to manually add the 2 lines in the ConfigureServices (https://github.com/net-daemon/netdaemon/blob/main/src/Runtime/NetDaemon.Runtime/Common/Extensions/HostBuilderExtensions.cs#L15-L16).

The proposed solution

Add an extension method on IServiceCollection that adds those 2 dependancies. This new method can be called from the existing HostbuilderExtensions.UseNetDaemonAppSettings to maintain backwards compatibility while allowing a single spot to add dependancies needed for the app. Therefore if someone chooses to manually set up the config providers they do not need to keep up on adding dependancies when changes are made in the future.

The alternatives

When someone wants to manually set up the config providers they have to manually add these 2 (and keep up with any changes in the UseNetDaemonAppSettings function).

Additional context

I would be happy to make the changes and PR if we like the idea.

[helto4real]

Sounds like a great idea. Look forward to PR.

[PartemImperium]

I have the changes working locally and the existing unit tests run. Do we want to add a unit test that checks that the new extension method adds the 2 dependencies to a ServiceCollection? Or is that more granular than we would want?

[helto4real]

Sorry I missed this one. Been really busy lately. Will check it out.

[helto4real]

I take that back.. From my phone this looked like a PR lool.

[skotl]

I have the changes working locally and the existing unit tests run. Do we want to add a unit test that checks that the new extension method adds the 2 dependencies to a ServiceCollection? Or is that more granular than we would want?

My feeling is no. That's pretty fundamental behaviour and it will be pretty obvious if this is missed.
Ideally we would also have some documentation for this (possibly referenced here: https://netdaemon.xyz/docs/v3/app_model/app_model_instancing) that should detail the additional steps required.

If you were to make the PR then we'd recommend also updating the docs project over at https://github.com/net-daemon/docs

[PartemImperium]

Closing as PR is merged.