Skip to content

Conversation

@eugeneniemand
Copy link
Member

Breaking change

Proposed change

This is to persist the TurnOn and TurnOff states. I have logic that relies on current state, so when I turn something on I expect to be able to use State("some.entity") to get its state. It currenty returns null so I have now implemented Mocks to persist state

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

@helto4real helto4real merged commit 74a2ab1 into net-daemon:dev Jan 27, 2021
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
Co-authored-by: Eugene Niemand <eugene.niemand@asos.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants