Skip to content

Conversation

@FrankBakkerNl
Copy link
Contributor

Proposed change

fix #560 Device with all numeric name prevents cache from loading

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

Codecov Report

Merging #612 (c9dc4ab) into dev (067de2f) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #612      +/-   ##
==========================================
+ Coverage   80.37%   80.44%   +0.06%     
==========================================
  Files         110      110              
  Lines        2889     2889              
  Branches      313      313              
==========================================
+ Hits         2322     2324       +2     
+ Misses        440      439       -1     
+ Partials      127      126       -1     
Flag Coverage Δ
unittests 80.44% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...assClient/Common/HomeAssistant/Model/HassDevice.cs 100.00% <ø> (ø)
...lient/Internal/Json/ReadNumberAsStringConverter.cs 54.54% <ø> (ø)
...mon.HassClient/Internal/HomeAssistantConnection.cs 86.66% <0.00%> (+1.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 067de2f...c9dc4ab. Read the comment docs.

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do a bugfix in v2 repo too?

@helto4real helto4real merged commit 80274cb into net-daemon:dev Jan 17, 2022
@FrankBakkerNl FrankBakkerNl deleted the fix_numericDeviceName branch December 22, 2022 22:29
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot convert number to string

3 participants