Skip to content

Conversation

@helto4real
Copy link
Collaborator

@helto4real helto4real commented Jan 17, 2022

Breaking change

Proposed change

Instead of using the integration to create persistant switches for app state we not use input_boolean helpers.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real changed the title use_helpers Use input booleans instead of switch for app state Jan 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2022

Codecov Report

Merging #613 (54dc76f) into dev (80274cb) will decrease coverage by 0.51%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #613      +/-   ##
==========================================
- Coverage   80.58%   80.06%   -0.52%     
==========================================
  Files         110      112       +2     
  Lines        2889     2900      +11     
  Branches      313      313              
==========================================
- Hits         2328     2322       -6     
- Misses        436      451      +15     
- Partials      125      127       +2     
Flag Coverage Δ
unittests 80.06% <0.00%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Common/Exceptions/HomeAssistantApiCallException.cs 0.00% <0.00%> (ø)
.../HomeAssistant/Commands/CreateHelperCommandBase.cs 0.00% <0.00%> (ø)
...mon.HassClient/Internal/HomeAssistantApiManager.cs 84.61% <0.00%> (ø)
...mon.HassClient/Internal/Net/WebSocketClientImpl.cs 68.42% <0.00%> (-7.90%) ⬇️
...mon.HassClient/Internal/HomeAssistantConnection.cs 84.76% <0.00%> (-1.91%) ⬇️
...sClient/Internal/Net/WebSocketTransportPipeline.cs 90.35% <0.00%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80274cb...54dc76f. Read the comment docs.

@helto4real helto4real enabled auto-merge (squash) January 17, 2022 23:03
@helto4real helto4real merged commit a3537f8 into dev Jan 17, 2022
@helto4real helto4real deleted the use_helpers branch January 17, 2022 23:05
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
* Use helpers for app-state

* Fix warning

* Review comments

* Fix Dispose at the end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants