-
-
Notifications
You must be signed in to change notification settings - Fork 80
Use input booleans instead of switch for app state #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Runtime/NetDaemon.Runtime/Internal/Model/ListInputBooleanHelperCommand.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #613 +/- ##
==========================================
- Coverage 80.58% 80.06% -0.52%
==========================================
Files 110 112 +2
Lines 2889 2900 +11
Branches 313 313
==========================================
- Hits 2328 2322 -6
- Misses 436 451 +15
- Partials 125 127 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
FrankBakkerNl
approved these changes
Jan 17, 2022
Ikcelaks
pushed a commit
to Ikcelaks/netdaemon
that referenced
this pull request
Dec 23, 2022
* Use helpers for app-state * Fix warning * Review comments * Fix Dispose at the end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Instead of using the integration to create persistant switches for app state we not use input_boolean helpers.
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: