Added HA add-on support the proper way #621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #621 +/- ##
==========================================
- Coverage 80.20% 80.13% -0.07%
==========================================
Files 112 112
Lines 2899 2899
Branches 309 309
==========================================
- Hits 2325 2323 -2
- Misses 448 451 +3
+ Partials 126 125 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
FrankBakkerNl
approved these changes
Jan 20, 2022
ludeeus
reviewed
Jan 20, 2022
| #!/usr/bin/with-contenv bash | ||
| echo "Starting NetDaemon Runner" | ||
| #!/usr/bin/with-contenv /usr/bin/bashio | ||
| echo "Starting NetDaemon Runner for add-on" |
Contributor
There was a problem hiding this comment.
Suggested change
| echo "Starting NetDaemon Runner for add-on" | |
| bashio::log.info "Starting NetDaemon Runner for add-on" |
Contributor
There was a problem hiding this comment.
bashio::log.* should be used for all echo stements
Comment on lines
58
to
59
| if [ ! -f ${Netdaemon__ApplicationAssembly} ]; | ||
| then |
Contributor
There was a problem hiding this comment.
Suggested change
| if [ ! -f ${Netdaemon__ApplicationAssembly} ]; | |
| then | |
| if ! bashio::fs.file_exists "${Netdaemon__ApplicationAssembly}"; then |
Comment on lines
61
to
62
| echo -e "\\033[31mThe assembly ${Netdaemon__ApplicationAssembly} cannot be found. Please check the settings.\\033[0m" >&2 | ||
| exit 1 |
Contributor
There was a problem hiding this comment.
Suggested change
| echo -e "\\033[31mThe assembly ${Netdaemon__ApplicationAssembly} cannot be found. Please check the settings.\\033[0m" >&2 | |
| exit 1 | |
| bashio::exit.nok "The assembly ${Netdaemon__ApplicationAssembly} cannot be found. Please check the settings." |
Comment on lines
76
to
77
| echo -e "\\033[31mCould not change directory to run custom project\\033[0m" >&2 | ||
| exit 1 |
Contributor
There was a problem hiding this comment.
Suggested change
| echo -e "\\033[31mCould not change directory to run custom project\\033[0m" >&2 | |
| exit 1 | |
| bashio::exit.nok "Could not change directory to run custom project" |
Ikcelaks
pushed a commit
to Ikcelaks/netdaemon
that referenced
this pull request
Dec 23, 2022
* Added HA add-on support the proper way * fix casing * Set needed environment using new env style * Fixed run script after review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Makes config of add-on containers the proper way using environment vars. Thanks @ludeeus for the input. This also allowed us to remove the special host created for add-on.
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: