Skip to content

Conversation

@helto4real
Copy link
Collaborator

@helto4real helto4real commented Jan 22, 2022

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2022

Codecov Report

Merging #626 (5493c1f) into dev (90db34e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #626   +/-   ##
=======================================
  Coverage   80.22%   80.22%           
=======================================
  Files         111      111           
  Lines        2903     2903           
  Branches      309      309           
=======================================
  Hits         2329     2329           
  Misses        447      447           
  Partials      127      127           
Flag Coverage Δ
unittests 80.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mon.HassClient/Internal/HomeAssistantConnection.cs 85.71% <0.00%> (-0.96%) ⬇️
...sClient/Internal/Net/WebSocketTransportPipeline.cs 91.22% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90db34e...5493c1f. Read the comment docs.

@helto4real helto4real merged commit 8db53d3 into dev Jan 22, 2022
@helto4real helto4real deleted the fix-run-dll branch January 22, 2022 22:16
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants