Skip to content

Conversation

@helto4real
Copy link
Collaborator

Breaking change

Proposed change

Fixes bug that prevent loading specific app types and assembly. Fix by doing smarter (correct) check for allready registerd appmodel and type resolvers.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real changed the title fix_adding_multiple_typeresolver Bugfix: Adding single type will prevent loading the whole assembly Jan 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #627 (c7a6b01) into dev (1d70bbc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #627   +/-   ##
=======================================
  Coverage   80.12%   80.12%           
=======================================
  Files         111      111           
  Lines        2903     2903           
  Branches      309      308    -1     
=======================================
  Hits         2326     2326           
  Misses        450      450           
  Partials      127      127           
Flag Coverage Δ
unittests 80.12% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...el/Common/Extensions/ServiceCollectionExtension.cs 93.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d70bbc...c7a6b01. Read the comment docs.

@helto4real helto4real enabled auto-merge (squash) January 23, 2022 07:41
@helto4real helto4real merged commit 9589da5 into dev Jan 23, 2022
@helto4real helto4real deleted the fix_adding_multiple_typeresolver branch January 23, 2022 08:51
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling AddAppFromType before AddAppsFromAssembly only discovers the app in the first call

4 participants