Skip to content

Conversation

@helto4real
Copy link
Collaborator

Breaking change

Proposed change

Always set ssl == false for add-on. Since we are communicating through supervisor proxy it is always no ssl and port 80.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.29%. Comparing base (9589da5) to head (694fbea).
⚠️ Report is 185 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #629      +/-   ##
==========================================
+ Coverage   80.26%   80.29%   +0.03%     
==========================================
  Files         111      111              
  Lines        2903     2903              
  Branches      308      308              
==========================================
+ Hits         2330     2331       +1     
  Misses        446      446              
+ Partials      127      126       -1     
Flag Coverage Δ
unittests 80.29% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@helto4real helto4real merged commit 19bfd8c into dev Jan 24, 2022
@helto4real helto4real deleted the bugfix_set_ssl_always_false_running_add-on branch January 24, 2022 11:38
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add-on uses ssl setting

4 participants