Skip to content

Conversation

@helto4real
Copy link
Collaborator

Breaking change

Proposed change

We add the integration tests again for V3 against current version, beta and dev release of Home Assistant

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real marked this pull request as draft January 23, 2022 19:10
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2022

Codecov Report

Merging #630 (3bd31c4) into dev (19bfd8c) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #630      +/-   ##
==========================================
+ Coverage   80.12%   80.22%   +0.10%     
==========================================
  Files         111      111              
  Lines        2903     2903              
  Branches      308      308              
==========================================
+ Hits         2326     2329       +3     
+ Misses        450      447       -3     
  Partials      127      127              
Flag Coverage Δ
unittests 80.22% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mon.HassClient/Internal/Net/WebSocketClientImpl.cs 69.44% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19bfd8c...3bd31c4. Read the comment docs.

@helto4real helto4real force-pushed the re-add-integration-tests branch 4 times, most recently from 906b34b to 9977da9 Compare January 24, 2022 10:59
@helto4real helto4real marked this pull request as ready for review January 24, 2022 11:00
@helto4real helto4real force-pushed the re-add-integration-tests branch from 9977da9 to 1f9b2d0 Compare January 24, 2022 11:10
@FrankBakkerNl FrankBakkerNl merged commit 4bdb079 into dev Jan 24, 2022
@FrankBakkerNl FrankBakkerNl deleted the re-add-integration-tests branch January 24, 2022 22:20
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants