Skip to content

fix: add missing brackets #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 28, 2022
Merged

fix: add missing brackets #635

merged 3 commits into from
Jan 28, 2022

Conversation

@BeeHiveJava
Copy link
Contributor

@BeeHiveJava BeeHiveJava commented Jan 28, 2022

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

FrankBakkerNl
FrankBakkerNl approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@FrankBakkerNl FrankBakkerNl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know a lot about bash, but it eems like that did not even work before right?

@FrankBakkerNl FrankBakkerNl merged commit fd32b48 into dev Jan 28, 2022
@FrankBakkerNl FrankBakkerNl deleted the bugfixes/if-statements branch January 28, 2022 21:18
@BeeHiveJava
Copy link
Contributor Author

BeeHiveJava commented Jan 28, 2022

Don't know a lot about bash, but it eems like that did not even work before right?

It shouldn't have 😄

Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
@BeeHiveJava
fix: add missing brackets (net-daemon#635)
9079841 
* fix: add missing brackets

* style: remove whitespace

* style: remove whitespaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FrankBakkerNl FrankBakkerNl FrankBakkerNl approved these changes

@ludeeus ludeeus ludeeus approved these changes

Assignees

No one assigned

Labels

pr: bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BeeHiveJava @FrankBakkerNl @ludeeus