Skip to content

Conversation

@helto4real
Copy link
Collaborator

Breaking change

Proposed change

Adds the forgotten HassModel.Integration to default host

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real enabled auto-merge (squash) January 28, 2022 21:31
@codecov-commenter
Copy link

Codecov Report

Merging #636 (7c499de) into dev (fd32b48) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #636      +/-   ##
==========================================
- Coverage   80.30%   80.13%   -0.18%     
==========================================
  Files         111      111              
  Lines        2904     2904              
  Branches      308      308              
==========================================
- Hits         2332     2327       -5     
- Misses        446      450       +4     
- Partials      126      127       +1     
Flag Coverage Δ
unittests 80.13% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mon.HassClient/Internal/Net/WebSocketClientImpl.cs 61.11% <0.00%> (-8.34%) ⬇️
...mon.HassClient/Internal/HomeAssistantConnection.cs 86.66% <0.00%> (-1.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd32b48...7c499de. Read the comment docs.

@helto4real helto4real merged commit 1dc8628 into dev Jan 28, 2022
@helto4real helto4real deleted the include_integration_dynamic branch January 28, 2022 23:10
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants