Add debug support for dynamic compiled apps #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #637 +/- ##
==========================================
+ Coverage 80.13% 80.15% +0.02%
==========================================
Files 111 111
Lines 2904 2898 -6
Branches 308 311 +3
==========================================
- Hits 2327 2323 -4
+ Misses 450 449 -1
+ Partials 127 126 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
BeeHiveJava
reviewed
Jan 29, 2022
src/AppModel/NetDaemon.AppModel/Common/Extensions/ServiceCollectionExtension.cs
Outdated
Show resolved
Hide resolved
BeeHiveJava
reviewed
Jan 29, 2022
src/AppModel/NetDaemon.AppModel/Internal/Compiler/CompilerFactory.cs
Outdated
Show resolved
Hide resolved
BeeHiveJava
reviewed
Jan 29, 2022
src/AppModel/NetDaemon.AppModel/Internal/Compiler/CompilerFactory.cs
Outdated
Show resolved
Hide resolved
BeeHiveJava
reviewed
Jan 29, 2022
helto4real
force-pushed
the
include_integration_dynamic
branch
from
c106d1c to
ceedf0d
Compare
Collaborator
Author
|
@BeeHiveJava I could not sleep so I ended up and doing the refactorings I wanted to do. Basically removed the factory pattern for compiler since I can use Compiler as singleton. This was on my todo list. Rather get it done now. |
src/AppModel/NetDaemon.AppModel/Internal/AssemblyResolver/AssemblyResolver.cs
Show resolved
Hide resolved
src/AppModel/NetDaemon.AppModel/Internal/Compiler/DebugSettings.cs
Outdated
Show resolved
Hide resolved
FrankBakkerNl
approved these changes
Jan 29, 2022
Contributor
FrankBakkerNl
left a comment
FrankBakkerNl
left a comment
There was a problem hiding this comment.
With one suggestion
Ikcelaks
pushed a commit
to Ikcelaks/netdaemon
that referenced
this pull request
Dec 23, 2022
* Added integration extension to default host * Add support to debug dynamically compiled programs * Change name to CompileSetting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Adds debug support for dynamic compiled apps.
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: