feat: introduce app instance factory to allow extending app instantiation logic #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #644 +/- ##
==========================================
- Coverage 80.53% 80.39% -0.14%
==========================================
Files 114 117 +3
Lines 2969 3004 +35
Branches 318 321 +3
==========================================
+ Hits 2391 2415 +24
- Misses 445 455 +10
- Partials 133 134 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
BeeHiveJava
force-pushed
the
features/app-instantiator
branch
from
c17d80e to
72383f4
Compare
src/AppModel/NetDaemon.AppModel/Internal/Instance/AppInstanceHelper.cs
Outdated
Show resolved
Hide resolved
src/AppModel/NetDaemon.AppModel.Tests/TypeResolver/TypeResolverTests.cs
Outdated
Show resolved
Hide resolved
src/AppModel/NetDaemon.AppModel/Internal/Instance/IAppInstance.cs
Outdated
Show resolved
Hide resolved
src/AppModel/NetDaemon.AppModel/Common/Extensions/ServiceCollectionExtension.cs
Outdated
Show resolved
Hide resolved
BeeHiveJava
force-pushed
the
features/app-instantiator
branch
from
b660a21 to
8802504
Compare
src/AppModel/NetDaemon.AppModel/Internal/AppAssemblyProvider/SingleAppAssemblyProvider.cs
Outdated
Show resolved
Hide resolved
src/AppModel/NetDaemon.AppModel/Internal/AppFactories/AppFactoryHelper.cs
Outdated
Show resolved
Hide resolved
src/AppModel/NetDaemon.AppModel/Internal/AppFactories/TypeAppFactory.cs
Outdated
Show resolved
Hide resolved
BeeHiveJava
force-pushed
the
features/app-instantiator
branch
from
74b0a9a to
8ab1284
Compare
helto4real
approved these changes
Jan 30, 2022
Collaborator
helto4real
left a comment
helto4real
left a comment
There was a problem hiding this comment.
I think you did an awesome job. The tests look really clean too!
src/AppModel/NetDaemon.AppModel/Common/Extensions/ServiceCollectionExtension.cs
Show resolved
Hide resolved
src/AppModel/NetDaemon.AppModel/Internal/TypeResolver/AppTypeResolver.cs
Show resolved
Hide resolved
Ikcelaks
pushed a commit
to Ikcelaks/netdaemon
that referenced
this pull request
Dec 23, 2022
…tion logic (net-daemon#644) * feat: add generic parameter for AddAppFromType * feat: introduce app instance factory * style: reformat * fix: use nullable property * feat: introduce app instances * refactor: modify names and layers based on discussions * refactor: rename namespaces to be plural * refactor: rename single app assembly provider * refactor: use factory methods instead of inheritance * fix: update tests * feat: move some tests around
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: