Skip to content

Remove_Common #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 31, 2022
Merged

Remove_Common #648

merged 7 commits into from
Jan 31, 2022

Conversation

@FrankBakkerNl
Copy link
Contributor

@FrankBakkerNl FrankBakkerNl commented Jan 31, 2022 •
edited
Loading

Breaking change

Moved all types from namsapce NetDaemon.HassModel.Common to NetDaemon.HassModel
and from NetDaemon.Client.Common to NetDaemon.Client

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@FrankBakkerNl FrankBakkerNl added the pr: breaking change Set it PR is breaking label Jan 31, 2022
helto4real
helto4real requested changes Jan 31, 2022
View reviewed changes
Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix integration tests please. The it looks good to mee

@helto4real helto4real merged commit 4b90185 into net-daemon:dev Jan 31, 2022
@FrankBakkerNl FrankBakkerNl deleted the Remove_Common branch December 22, 2022 22:23
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
@FrankBakkerNl @helto4real
Remove_Common (net-daemon#648)
8f34b8d 
* Rename NetDaemon.HassModel.Common into NetDaemon.HassModel

* HassModel file scoped namespaces and Global using

* Rename NetDaemon.Client.Common into NetDaemon.Client

* removed common from test project

* Remove common from integration tests

Co-authored-by: Tomas Hellström <tomas.hellstrom@yahoo.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@helto4real helto4real helto4real approved these changes

Assignees

No one assigned

Labels

pr: breaking change Set it PR is breaking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FrankBakkerNl @helto4real