Skip to content

Conversation

@FrankBakkerNl
Copy link
Contributor

Proposed change

For services that do not provide a selector for their fields we now generate object arguments instead of strings

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

Codecov Report

Merging #649 (348e8f3) into dev (4b90185) will increase coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #649      +/-   ##
==========================================
+ Coverage   80.54%   80.60%   +0.06%     
==========================================
  Files         116      116              
  Lines        2996     2996              
  Branches      321      321              
==========================================
+ Hits         2413     2415       +2     
+ Misses        449      448       -1     
+ Partials      134      133       -1     
Flag Coverage Δ
unittests 80.60% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...CodeGenerator/Helpers/HassServiceArgumentMapper.cs 71.42% <0.00%> (ø)
...mon.HassClient/Internal/HomeAssistantConnection.cs 88.57% <0.00%> (+1.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b90185...348e8f3. Read the comment docs.

@helto4real helto4real merged commit 7b7f8bd into net-daemon:dev Jan 31, 2022
@FrankBakkerNl FrankBakkerNl deleted the codegen_objectfield branch December 22, 2022 22:23
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
…lector (net-daemon#649)

Co-authored-by: Tomas Hellström <tomas.hellstrom@yahoo.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants