Skip to content

FocusFilter #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 1, 2022
Merged

FocusFilter #652

merged 5 commits into from
Feb 1, 2022

Conversation

@FrankBakkerNl
Copy link
Contributor

@FrankBakkerNl FrankBakkerNl commented Feb 1, 2022

Proposed change

Apply focus App only while in Development environment and log messages about Focus like in V2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

helto4real
helto4real approved these changes Feb 1, 2022
View reviewed changes
Copy link
Collaborator

@helto4real helto4real left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me when CI is OK. I had one comment. Please check that one before merge.

BeeHiveJava
BeeHiveJava reviewed Feb 1, 2022
View reviewed changes
@FrankBakkerNl FrankBakkerNl merged commit 9097887 into net-daemon:dev Feb 1, 2022
@FrankBakkerNl FrankBakkerNl deleted the FocusFilter branch December 22, 2022 22:24
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
@FrankBakkerNl @BeeHiveJava
FocusFilter (net-daemon#652)
79767e0 
* Filter focus apps only in Development environment

* Update src/AppModel/NetDaemon.AppModel/Internal/AppModelContext.cs

Co-authored-by: BeeHiveJava <BeeHiveJava@users.noreply.github.com>

* Update src/AppModel/NetDaemon.AppModel/Internal/AppModelContext.cs

Co-authored-by: BeeHiveJava <BeeHiveJava@users.noreply.github.com>

* Fix test

Co-authored-by: BeeHiveJava <BeeHiveJava@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@helto4real helto4real helto4real approved these changes

+1 more reviewer

@BeeHiveJava BeeHiveJava BeeHiveJava left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FrankBakkerNl @BeeHiveJava @helto4real