Skip to content

Add background task tracking and proper error handling #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 1, 2022
Merged

Add background task tracking and proper error handling #653

merged 3 commits into from
Feb 1, 2022

Conversation

@helto4real
Copy link
Collaborator

@helto4real helto4real commented Feb 1, 2022

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real force-pushed the log-errors-in-results branch from 83c8e9e to 54528c1 Compare February 1, 2022 13:15
@helto4real helto4real merged commit 3bda44b into dev Feb 1, 2022
@helto4real helto4real deleted the log-errors-in-results branch February 1, 2022 20:19
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
@helto4real
Add background task tracking and proper error handling (net-daemon#653)
a28d094 
* Adding tracking of background tasks and proper logging

* Added dispose async to wait for tasks

* Made it scoped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FrankBakkerNl FrankBakkerNl FrankBakkerNl approved these changes

Assignees

No one assigned

Labels

pr: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@helto4real @FrankBakkerNl