Skip to content

Conversation

@helto4real
Copy link
Collaborator

Breaking change

This will be breaking. Apps will be called with different names.

Proposed change

Changed to real snake casing.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real marked this pull request as ready for review February 1, 2022 20:56
@helto4real helto4real enabled auto-merge (squash) February 2, 2022 17:19
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022

Codecov Report

Merging #654 (86e80d2) into dev (596b4b6) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #654      +/-   ##
==========================================
- Coverage   80.71%   80.55%   -0.17%     
==========================================
  Files         118      118              
  Lines        3039     3039              
  Branches      325      325              
==========================================
- Hits         2453     2448       -5     
- Misses        452      456       +4     
- Partials      134      135       +1     
Flag Coverage Δ
unittests 80.55% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mon.HassClient/Internal/Net/WebSocketClientImpl.cs 61.11% <0.00%> (-8.34%) ⬇️
...mon.HassClient/Internal/HomeAssistantConnection.cs 86.66% <0.00%> (-1.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 596b4b6...86e80d2. Read the comment docs.

@helto4real helto4real merged commit 9955723 into dev Feb 2, 2022
@helto4real helto4real deleted the snake-casing-for-apps branch February 2, 2022 21:07
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
* fixed snake case naming of app input boolean

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants