Skip to content

Conversation

@helto4real
Copy link
Collaborator

@helto4real helto4real commented Feb 3, 2022

Breaking change

Proposed change

Removes unused input boolean helpers for non existing apps

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #657 (091b69f) into dev (9955723) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #657   +/-   ##
=======================================
  Coverage   80.55%   80.55%           
=======================================
  Files         118      118           
  Lines        3039     3039           
  Branches      325      325           
=======================================
  Hits         2448     2448           
  Misses        456      456           
  Partials      135      135           
Flag Coverage Δ
unittests 80.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9955723...091b69f. Read the comment docs.

Copy link
Contributor

@FrankBakkerNl FrankBakkerNl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finishe review, just some minors

@helto4real helto4real enabled auto-merge (squash) February 3, 2022 22:09
@helto4real helto4real merged commit 7ae0652 into dev Feb 4, 2022
@helto4real helto4real deleted the remove-not-used-app-states branch February 4, 2022 09:54
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
* Remove unused input booleans on NetDaemon runtime start

* And the tests

* Review fix

* Review new line

* switch -> if
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants