Skip to content

Conversation

@helto4real
Copy link
Collaborator

Breaking change

Proposed change

Adds specific naming rules for when is in development for input booleans app states

When in development:

  • The feature that removes unused apps is disabled
  • A prefix dev_ is added not to interfere with original
  • The dev version will be removed when production restarts

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022

Codecov Report

Merging #659 (dabea40) into dev (041cc01) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #659      +/-   ##
==========================================
+ Coverage   80.55%   80.71%   +0.16%     
==========================================
  Files         118      118              
  Lines        3039     3039              
  Branches      325      325              
==========================================
+ Hits         2448     2453       +5     
+ Misses        456      452       -4     
+ Partials      135      134       -1     
Flag Coverage Δ
unittests 80.71% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mon.HassClient/Internal/HomeAssistantConnection.cs 88.57% <0.00%> (+1.90%) ⬆️
...mon.HassClient/Internal/Net/WebSocketClientImpl.cs 69.44% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 041cc01...dabea40. Read the comment docs.


var appStateManager = scopedProvider.ServiceProvider.GetRequiredService<IAppStateManager>();
var appStateManager = provider.GetRequiredService<IAppStateManager>();

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have these cleaned up 👍

@helto4real helto4real enabled auto-merge (squash) February 5, 2022 14:33
@helto4real helto4real merged commit d719407 into dev Feb 5, 2022
@helto4real helto4real deleted the dev-fix-helper-naming branch February 5, 2022 14:35
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants