SubscribeSafe #733
Merged
SubscribeSafe #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #733 +/- ##
==========================================
- Coverage 78.32% 77.67% -0.66%
==========================================
Files 139 139
Lines 3576 3624 +48
Branches 363 367 +4
==========================================
+ Hits 2801 2815 +14
- Misses 630 663 +33
- Partials 145 146 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
BeeHiveJava
reviewed
Jul 22, 2022
Collaborator
Author
|
Merging this due to low activity on reviews |
Ikcelaks
pushed a commit
to Ikcelaks/netdaemon
that referenced
this pull request
Dec 23, 2022
* SubscribeSafe added. * Added ILogger overload * Fixed check if logger exists before creating factory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Changes behaviour of SubscribeAsync and SubscribeAsyncConcurrent to safely recover from unhandled exception. This was the intended behaviour from the beginning so technically it is a bugfix.
Proposed change
This PR adds a safe subscription. Safe means it will recover from unhandled exceptions and continue process messages. Normal Subscribe would unsubscribe all subscribers when unhandled exceptions occurs.
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: