Skip to content

Conversation

@helto4real
Copy link
Collaborator

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

Codecov Report

Merging #749 (1643a08) into dev (42ccaa2) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #749      +/-   ##
==========================================
+ Coverage   77.62%   77.68%   +0.05%     
==========================================
  Files         139      139              
  Lines        3607     3607              
  Branches      365      365              
==========================================
+ Hits         2800     2802       +2     
+ Misses        663      662       -1     
+ Partials      144      143       -1     
Flag Coverage Δ
unittests 77.68% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mon.HassClient/Internal/HomeAssistantConnection.cs 88.79% <0.00%> (+1.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@helto4real helto4real enabled auto-merge (squash) September 11, 2022 08:30
Copy link
Contributor

@ThomasCulotta ThomasCulotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward 👍

@helto4real helto4real disabled auto-merge September 11, 2022 09:25
@helto4real helto4real merged commit 26ae3ec into dev Sep 11, 2022
@helto4real helto4real deleted the deps_upgrades branch September 11, 2022 09:25
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants