Skip to content

Conversation

@helto4real
Copy link
Collaborator

Breaking change

Proposed change

This PR makes sure the version of nuget assemblies is same as nuget package version.
Also updates nuget packages to latest version.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

Codecov Report

Base: 77.62% // Head: 77.62% // No change to project coverage 👍

Coverage data is based on head (3efd0c3) compared to base (c6635dd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #760   +/-   ##
=======================================
  Coverage   77.62%   77.62%           
=======================================
  Files         139      139           
  Lines        3607     3607           
  Branches      365      365           
=======================================
  Hits         2800     2800           
  Misses        663      663           
  Partials      144      144           
Flag Coverage Δ
unittests 77.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@helto4real helto4real enabled auto-merge (squash) October 4, 2022 16:33
@helto4real helto4real disabled auto-merge October 4, 2022 16:51
@helto4real helto4real merged commit 84ff98b into dev Oct 4, 2022
@helto4real helto4real deleted the versioning_and_maintainence branch October 4, 2022 16:51
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
* Nuget updates

* Versioning of assemblies match version of nuget package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants