-
-
Notifications
You must be signed in to change notification settings - Fork 80
Allow running NetDaemon in AspNetCore #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| services.AddHostedService<RuntimeService>(); | ||
| services.AddHomeAssistantClient(); | ||
|
|
||
| services.Configure<HomeAssistantSettings>(context.Configuration.GetSection("HomeAssistant")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea this change seem valid! I This is how it should been from the start when I think about it.
helto4real
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just som minor thoughts
Codecov ReportBase: 77.09% // Head: 77.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #764 +/- ##
==========================================
+ Coverage 77.09% 77.13% +0.04%
==========================================
Files 141 141
Lines 3667 3661 -6
Branches 365 365
==========================================
- Hits 2827 2824 -3
+ Misses 696 693 -3
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
helto4real
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good mate!
Breaking change
Proposed change
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: