Skip to content

Conversation

@helto4real
Copy link
Collaborator

@helto4real helto4real commented Nov 22, 2022

Breaking change

You are now required to use .NET 7 when developing NetDaemon apps.

Proposed change

Upgrades to latest .NET 7 for NetDaemon components. The C# 11 features are not enabled in this PR. There will be a separate PR for this.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Base: 77.16% // Head: 77.92% // Increases project coverage by +0.76% 🎉

Coverage data is based on head (8037f31) compared to base (3de32f3).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #786      +/-   ##
==========================================
+ Coverage   77.16%   77.92%   +0.76%     
==========================================
  Files         141      152      +11     
  Lines        3661     4000     +339     
  Branches      365      403      +38     
==========================================
+ Hits         2825     3117     +292     
- Misses        693      722      +29     
- Partials      143      161      +18     
Flag Coverage Δ
unittests 77.92% <75.00%> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mmon/Extensions/IConfigurationBuilderExtensions.cs 93.54% <0.00%> (-3.23%) ⬇️
...n.AppModel/Internal/Config/ConfigurationBinding.cs 78.83% <ø> (ø)
...el/NetDaemon.AppModel/Internal/Config/AppConfig.cs 92.85% <100.00%> (ø)
...aemon.HassModel.CodeGenerator/EntitiesGenerator.cs 98.79% <100.00%> (ø)
...ime/NetDaemon.Runtime/Internal/Model/HassHelper.cs 66.66% <0.00%> (ø)
...e/NetDaemon.Runtime/Internal/AppStateRepository.cs 87.50% <0.00%> (ø)
.../Internal/Model/CreateInputBooleanHelperCommand.cs 100.00% <0.00%> (ø)
...ntime/NetDaemon.Runtime/Internal/RuntimeService.cs 94.44% <0.00%> (ø)
...e/NetDaemon.Runtime/Internal/EntityMapperHelper.cs 88.46% <0.00%> (ø)
...time/NetDaemon.Runtime/Internal/AppStateManager.cs 86.76% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@helto4real helto4real merged commit 448355f into dev Nov 22, 2022
@helto4real helto4real deleted the net7 branch November 22, 2022 21:49
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
* .NET 7 support

* Fix case warning

* Test CI codecov

* Test different order of msbuild parameters

* Another try

* Fix output typo (net-daemon#787)

* Fix test timing

* Fix PR comments

* NetDaemon.Tests.Integration.csproj to .Net 7

Co-authored-by: Joakim Sørensen <ludeeus@ludeeus.dev>
Co-authored-by: Frank Bakker <FrankBakkerNl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants