Skip to content

Conversation

@FrankBakkerNl
Copy link
Contributor

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@FrankBakkerNl FrankBakkerNl changed the title Dummy to test build Fix CS1852 violations Dec 15, 2022
@FrankBakkerNl FrankBakkerNl changed the title Fix CS1852 violations Fix CA1852 violations Dec 15, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 78.00% // Head: 77.35% // Decreases project coverage by -0.64% ⚠️

Coverage data is based on head (6d127cd) compared to base (1cf015d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #808      +/-   ##
==========================================
- Coverage   78.00%   77.35%   -0.65%     
==========================================
  Files         152      141      -11     
  Lines        4005     3666     -339     
  Branches      404      369      -35     
==========================================
- Hits         3124     2836     -288     
+ Misses        721      688      -33     
+ Partials      160      142      -18     
Flag Coverage Δ
unittests 77.35% <ø> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Common/Exceptions/HomeAssistantApiCallException.cs 0.00% <0.00%> (-100.00%) ⬇️
...del/NetDaemon.AppModel/Internal/AppModelContext.cs 66.66% <0.00%> (-33.34%) ⬇️
...el/NetDeamon.HassModel/DependencyInjectionSetup.cs 68.75% <0.00%> (-25.00%) ⬇️
...Deamon.HassModel/Internal/BackgroundTaskTracker.cs 78.57% <0.00%> (-7.15%) ⬇️
...n.AppModel/Internal/AppFactories/FuncAppFactory.cs 87.09% <0.00%> (-3.23%) ⬇️
...e/NetDaemon.Runtime/Internal/EntityMapperHelper.cs
...ime/NetDaemon.Runtime/Internal/Model/HassHelper.cs
...time/NetDaemon.Runtime/Internal/AppStateManager.cs
.../Internal/Model/CreateInputBooleanHelperCommand.cs
...Runtime/Common/Extensions/HostBuilderExtensions.cs
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FrankBakkerNl FrankBakkerNl enabled auto-merge (squash) December 15, 2022 21:19
@FrankBakkerNl FrankBakkerNl merged commit 7212b79 into net-daemon:dev Dec 16, 2022
helto4real pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 17, 2022
@FrankBakkerNl FrankBakkerNl deleted the TestPrBuild branch December 17, 2022 18:13
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants