Fix #728 where extension methods were generated for typed entity clas… #813
Conversation
…ntity classes that do not exist because the user has no entities for them
Codecov ReportBase: 77.86% // Head: 77.84% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #813 +/- ##
==========================================
- Coverage 77.86% 77.84% -0.02%
==========================================
Files 158 158
Lines 4142 4134 -8
Branches 419 419
==========================================
- Hits 3225 3218 -7
Misses 753 753
+ Partials 164 163 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
|
||
| code.ToString().Should().NotContain("humidifiers", because:"There is no entity for domain humidifiers"); | ||
| code.ToString().Should().NotContain("DumbthingsEntityExtensionMethods", because:"There is no entity for any of the services in dumbthings"); | ||
|
|
There was a problem hiding this comment.
I think this test should be split into two tests. One to test that methods are only created when the target domain has entities (the "smart_things" service domain here) and a second to test that empty extension method classes aren't created for service domains that don't have any eligible methods (the "dumbthings" service domain here). But, this is pedantic.
There was a problem hiding this comment.
Yes this does make it more clear, split them up
FrankBakkerNl
deleted the
fix_728_SkipExtensionMethodForNonExisitingEntitytype
branch
…ntity clas… (net-daemon#813) * Fix net-daemon#728 where extension methods were generated for typed entity classes that do not exist because the user has no entities for them * split test
4 participants
Fix #728 where extension methods were generated for typed entity classes that do not exist because the user has no entities for them
Breaking change
Proposed change
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: