-
-
Notifications
You must be signed in to change notification settings - Fork 80
Add option to specify Cron Job with Seconds #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to specify Cron Job with Seconds #828
Conversation
Codecov ReportBase: 81.10% // Head: 80.84% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #828 +/- ##
==========================================
- Coverage 81.10% 80.84% -0.27%
==========================================
Files 159 159
Lines 4106 4092 -14
Branches 405 404 -1
==========================================
- Hits 3330 3308 -22
- Misses 616 621 +5
- Partials 160 163 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| count.Should().Be(3, because: "Action should not fire after Dispose()"); | ||
| #endregion | ||
|
|
||
| #region Cron with Seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not a separate test instead of regions?
Also this does not really test the seconds really work, but you could argue that is a feature or Cron.Net and not this extansion
Proposed change
Modify the CronExtensions to handle cron strings with seconds specified. Cronos supports this but the underlying call to Parse needs to specify the format beforehand. I opted to add a default boolean to the existing call to avoid a breaking change.
Type of change
Additional information
None
Checklist
If user exposed functionality or configuration variables are added/changed: