Skip to content

Conversation

@FrankBakkerNl
Copy link
Contributor

@FrankBakkerNl FrankBakkerNl commented Feb 2, 2023

Proposed change

If there are duplicates after PascalCasing EntityId's use the original EntityId's instead

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 80.93% // Head: 81.10% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (5ecc71c) compared to base (e30122f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #832      +/-   ##
==========================================
+ Coverage   80.93%   81.10%   +0.16%     
==========================================
  Files         159      159              
  Lines        4096     4106      +10     
  Branches      405      405              
==========================================
+ Hits         3315     3330      +15     
+ Misses        618      616       -2     
+ Partials      163      160       -3     
Flag Coverage Δ
unittests 81.10% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
....CodeGenerator/CodeGeneration/EntitiesGenerator.cs 100.00% <100.00%> (ø)
...l.CodeGenerator/CodeGeneration/ServiceArguments.cs 94.59% <100.00%> (+2.70%) ⬆️
...Model.CodeGenerator/Extensions/StringExtensions.cs 100.00% <100.00%> (+6.25%) ⬆️
...on.HassModel.CodeGenerator/Helpers/NamingHelper.cs 89.79% <100.00%> (-0.78%) ⬇️
...aData/EntityMetaData/AttributeMetaDataGenerator.cs 89.47% <100.00%> (ø)
...or/MetaData/EntityMetaData/EntityDomainMetadata.cs 100.00% <100.00%> (ø)
...MetaData/EntityMetaData/EntityMetaDataGenerator.cs 97.14% <100.00%> (+2.14%) ⬆️
...mon.HassClient/Internal/HomeAssistantConnection.cs 88.79% <0.00%> (+1.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@helto4real helto4real merged commit 94d6465 into net-daemon:dev Feb 2, 2023
@FrankBakkerNl FrankBakkerNl deleted the fix830_duplicateEntityPropertyName branch February 6, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential duplicate entities after CodeGen normalization

2 participants