-
-
Notifications
You must be signed in to change notification settings - Fork 80
MeansImplicitUse for NetDaemonAppAttribute #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I like this idea, If I am correct there is a similar attributes in a MS namespace somewhere, that should probably work with both jet brains ans MS IDE and we would not have to reference JB packages |
|
Thank you for the contribution. I am reluctant to add this into the core since it is dependent on specific IDE:s. Is this possible to add as an Extension instead. I know the attribute class is sealed so I cannot see a good solution to it right now. @FrankBakkerNl ? |
…to get rid of nuget dependency
|
I've added the needed code directly as an internal class as stated on this site: https://blog.jetbrains.com/dotnet/2018/05/03/what-are-jetbrains-annotations/ So we can get rid of the nuget dependency. @FrankBakkerNl I couldn't find anything similar in the MS namespace. JetBrains normally provides info about such attributes. For example the PureAttribute: https://www.jetbrains.com/help/resharper/Reference__Code_Annotation_Attributes.html#PureAttribute |
|
This is nice indeed, now Rider will no longer show my app classes in gray :-) |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## dev #852 +/- ##
==========================================
- Coverage 80.93% 80.68% -0.25%
==========================================
Files 160 161 +1
Lines 4127 4137 +10
Branches 410 410
==========================================
- Hits 3340 3338 -2
- Misses 625 636 +11
- Partials 162 163 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Yea this is much better solution. I accept that. Good solution. Thanks! |
Proposed change
Adds the JetBrains MeansImplicitUse to the NetDaemonAppAttribute.
Helps R# and Rider to mark classes as used if the NetDeamonAppAttribute is used
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: