Skip to content

Conversation

@FrankBakkerNl
Copy link
Contributor

@FrankBakkerNl FrankBakkerNl commented Apr 6, 2023

Breaking change

Proposed change

Fixes the incompatibility with HA version 2023.4.0 and greater.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage: 77.77% and project coverage change: +0.09 🎉

Comparison is base (7fbcc0f) 80.61% compared to head (ab95efb) 80.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #858      +/-   ##
==========================================
+ Coverage   80.61%   80.70%   +0.09%     
==========================================
  Files         161      162       +1     
  Lines        4137     4142       +5     
  Branches      410      411       +1     
==========================================
+ Hits         3335     3343       +8     
+ Misses        639      636       -3     
  Partials      163      163              
Flag Coverage Δ
unittests 80.70% <77.77%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erator/CodeGeneration/ExtensionMethodsGenerator.cs 98.52% <0.00%> (ø)
...a/ServicesMetaData/SingleObjectAsArrayConverter.cs 85.71% <85.71%> (ø)
...deGenerator/MetaData/ServicesMetaData/Selectors.cs 47.05% <100.00%> (+4.95%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@helto4real
Copy link
Collaborator

Fixes #857

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and fast fix. Thanks alot!

@helto4real helto4real merged commit 4b5b3c4 into net-daemon:dev Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code generation breaks with current beta / release

2 participants