Skip to content

Conversation

@helto4real
Copy link
Collaborator

@helto4real helto4real commented Apr 6, 2023

Breaking change

Proposed change

Adding code generation tests in the integration tests so we can be alerted in a timely fashion if HA changes API that affects the code generator. This is due to recent events where changes in service descriptors broke code generation.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real changed the title Adding code generation tests in the integration tests so we can be alerted in a timely fashion if HA changes API that affects the code generator. Adding code generation tests in the integration tests. Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4b5b3c4) 80.70% compared to head (68c4dac) 80.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #859   +/-   ##
=======================================
  Coverage   80.70%   80.70%           
=======================================
  Files         162      162           
  Lines        4142     4142           
  Branches      411      411           
=======================================
  Hits         3343     3343           
  Misses        636      636           
  Partials      163      163           
Flag Coverage Δ
unittests 80.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FrankBakkerNl FrankBakkerNl merged commit b3dc9e4 into dev Apr 6, 2023
@FrankBakkerNl FrankBakkerNl deleted the codegen-integration-tests branch April 6, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants