Skip to content

Conversation

@helto4real
Copy link
Collaborator

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.13 🎉

Comparison is base (4b5b3c4) 80.70% compared to head (4514709) 80.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #860      +/-   ##
==========================================
+ Coverage   80.70%   80.84%   +0.13%     
==========================================
  Files         162      167       +5     
  Lines        4142     4213      +71     
  Branches      411      419       +8     
==========================================
+ Hits         3343     3406      +63     
- Misses        636      637       +1     
- Partials      163      170       +7     
Flag Coverage Δ
unittests 80.84% <85.71%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...el/NetDeamon.HassModel/TriggerManagerExtensions.cs 0.00% <0.00%> (ø)
...mon.HassClient/Internal/HomeAssistantConnection.cs 86.06% <83.33%> (-1.01%) ⬇️
...t/Extensions/IHomeAssistantConnectionExtensions.cs 89.47% <84.61%> (-1.01%) ⬇️
...del/NetDeamon.HassModel/Internal/TriggerManager.cs 90.90% <90.90%> (ø)
...HassClient/Common/HomeAssistant/Model/HassEvent.cs 100.00% <100.00%> (ø)
...sClient/Common/HomeAssistant/Model/HassVariable.cs 100.00% <100.00%> (ø)
.../HomeAssistant/Commands/SubscribeTriggerCommand.cs 100.00% <100.00%> (ø)
...HomeAssistant/Commands/UnsubscribeEventsCommand.cs 100.00% <100.00%> (ø)
...el/NetDeamon.HassModel/DependencyInjectionSetup.cs 94.11% <100.00%> (+0.36%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FrankBakkerNl FrankBakkerNl marked this pull request as ready for review April 14, 2023 20:29
Copy link
Collaborator Author

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@FrankBakkerNl FrankBakkerNl merged commit 22e8e70 into dev Apr 15, 2023
@FrankBakkerNl FrankBakkerNl deleted the trigger-support-in-client branch April 15, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants