Skip to content

Conversation

@Rick-van-Dam
Copy link
Contributor

@Rick-van-Dam Rick-van-Dam commented Apr 18, 2023

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (24878c8) 80.77% compared to head (9e8d3de) 80.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #862      +/-   ##
==========================================
+ Coverage   80.77%   80.79%   +0.01%     
==========================================
  Files         167      167              
  Lines        4213     4217       +4     
  Branches      419      419              
==========================================
+ Hits         3403     3407       +4     
  Misses        640      640              
  Partials      170      170              
Flag Coverage Δ
unittests 80.79% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...el/NetDeamon.HassModel/DependencyInjectionSetup.cs 94.44% <100.00%> (+0.32%) ⬆️
...del/NetDeamon.HassModel/Internal/TriggerManager.cs 91.66% <100.00%> (+0.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good man

@helto4real helto4real merged commit e65e34d into net-daemon:dev Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants