Skip to content

Conversation

@helto4real
Copy link
Collaborator

Breaking change

Proposed change

Adding support for coalesce messages from the websocket. This is a optimization from Home Assistant version 2022.9.0 that optimizes network traffic by sending multiple messages in one message to save rountrips.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real changed the title coalesce-support Websocket optimization (Coalesce support) May 4, 2023
@helto4real helto4real marked this pull request as ready for review May 5, 2023 18:41
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 73.46% and project coverage change: -0.05 ⚠️

Comparison is base (b9a80aa) 80.74% compared to head (7b2ce42) 80.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #870      +/-   ##
==========================================
- Coverage   80.74%   80.70%   -0.05%     
==========================================
  Files         168      170       +2     
  Lines        4244     4280      +36     
  Branches      423      429       +6     
==========================================
+ Hits         3427     3454      +27     
- Misses        642      648       +6     
- Partials      175      178       +3     
Flag Coverage Δ
unittests 80.70% <73.46%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sClient/Internal/Net/WebSocketTransportPipeline.cs 86.88% <36.36%> (-4.35%) ⬇️
...tDaemon.HassClient/Internal/HomeAssistantClient.cs 83.52% <76.92%> (+1.43%) ⬆️
...ent/Common/HomeAssistant/Model/HassAuthResponse.cs 100.00% <100.00%> (ø)
...HomeAssistant/Commands/SupportedFeaturesCommand.cs 100.00% <100.00%> (ø)
...mon.HassClient/Internal/HomeAssistantConnection.cs 87.50% <100.00%> (+0.28%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FrankBakkerNl FrankBakkerNl merged commit 75eb52b into dev May 7, 2023
@FrankBakkerNl FrankBakkerNl deleted the coalesce-support branch May 7, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants