Skip to content

Conversation

@mcinnes01
Copy link
Contributor

@mcinnes01 mcinnes01 commented Jun 29, 2023

Breaking change

Proposed change

Fix beta version handling of ha

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. Great job! Since we are now use custom regex please provide a separate helper class and a test for it so we can prove it can parse both beta and non beta versions.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e843d37) 80.72% compared to head (efe7856) 80.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #888   +/-   ##
=======================================
  Coverage   80.72%   80.72%           
=======================================
  Files         170      171    +1     
  Lines        4280     4281    +1     
  Branches      430      430           
=======================================
+ Hits         3455     3456    +1     
  Misses        648      648           
  Partials      177      177           
Flag Coverage Δ
unittests 80.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...aemon.HassClient/Internal/Helpers/VersionHelper.cs 100.00% <100.00%> (ø)
...tDaemon.HassClient/Internal/HomeAssistantClient.cs 83.52% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mcinnes01 mcinnes01 requested a review from helto4real June 29, 2023 13:47
Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good mate!

@helto4real helto4real merged commit 6038eb1 into net-daemon:dev Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants