Skip to content

Conversation

@helto4real
Copy link
Collaborator

Breaking change

Proposed change

This PR removes the integration tests from default test run. This will make it easier for contributors when their loka tests pass it will likely pass later too. The integration tests will run when PR is created.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6038eb1) 80.77% compared to head (1d3d28e) 80.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #889   +/-   ##
=======================================
  Coverage   80.77%   80.77%           
=======================================
  Files         171      171           
  Lines        4281     4281           
  Branches      430      430           
=======================================
  Hits         3458     3458           
  Misses        647      647           
  Partials      176      176           
Flag Coverage Δ
unittests 80.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@helto4real helto4real merged commit d2979f6 into dev Jul 2, 2023
@helto4real helto4real deleted the remove-integrationtests-from-ci branch July 2, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants