-
-
Notifications
You must be signed in to change notification settings - Fork 80
Use testcontainers for integration tests #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...ion/NetDaemon.Tests.Integration/Helpers/HomeAssistantTestContainer/HomeAssistantContainer.cs
Show resolved
Hide resolved
tests/Integration/NetDaemon.Tests.Integration/NetDaemon.Tests.Integration.csproj
Show resolved
Hide resolved
tests/Integration/NetDaemon.Tests.Integration/Helpers/HomeAssistantLifetime.cs
Show resolved
Hide resolved
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## dev #893 +/- ##
==========================================
- Coverage 80.77% 80.72% -0.05%
==========================================
Files 171 171
Lines 4281 4281
Branches 430 430
==========================================
- Hits 3458 3456 -2
- Misses 647 648 +1
- Partials 176 177 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
helto4real
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you spent a lot of time getting this to work but the end-result seem really simple. We can build from this, adding more tests etc. Great job. Will approve as soon as the CI jobs are updated.
...ion/NetDaemon.Tests.Integration/Helpers/HomeAssistantTestContainer/HomeAssistantContainer.cs
Show resolved
Hide resolved
...ion/NetDaemon.Tests.Integration/Helpers/HomeAssistantTestContainer/HomeAssistantContainer.cs
Show resolved
Hide resolved
...Daemon.Tests.Integration/Helpers/HomeAssistantTestContainer/HomeAssistantContainerBuilder.cs
Outdated
Show resolved
Hide resolved
tests/Integration/NetDaemon.Tests.Integration/Helpers/HomeAssistantLifetime.cs
Show resolved
Hide resolved
helto4real
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks alot for this!
Breaking change
This will break the existing integration build.
Proposed change
Use the testcontaiers library to automatically launch a homeassistant docker container in order to run integration tests. Except for having docker installed the user does not have to setup anything manually.
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: