Skip to content

Conversation

@Rick-van-Dam
Copy link
Contributor

Breaking change

This will break the existing integration build.

Proposed change

Use the testcontaiers library to automatically launch a homeassistant docker container in order to run integration tests. Except for having docker installed the user does not have to setup anything manually.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (d2979f6) 80.77% compared to head (34e995f) 80.72%.

❗ Current head 34e995f differs from pull request most recent head a34bf95. Consider uploading reports for the commit a34bf95 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #893      +/-   ##
==========================================
- Coverage   80.77%   80.72%   -0.05%     
==========================================
  Files         171      171              
  Lines        4281     4281              
  Branches      430      430              
==========================================
- Hits         3458     3456       -2     
- Misses        647      648       +1     
- Partials      176      177       +1     
Flag Coverage Δ
unittests 80.72% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you spent a lot of time getting this to work but the end-result seem really simple. We can build from this, adding more tests etc. Great job. Will approve as soon as the CI jobs are updated.

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks alot for this!

@helto4real helto4real merged commit 204755d into net-daemon:dev Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants