-
-
Notifications
You must be signed in to change notification settings - Fork 80
Add interfaces #897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interfaces #897
Conversation
src/HassModel/NetDeamon.HassModel/Entities/Interfaces/IOnOffTarget.cs
Outdated
Show resolved
Hide resolved
src/HassModel/NetDeamon.HassModel/Entities/Interfaces/IOnOffTarget.cs
Outdated
Show resolved
Hide resolved
src/HassModel/NetDeamon.HassModel/Entities/Interfaces/IOnOffTarget.cs
Outdated
Show resolved
Hide resolved
src/HassModel/NetDeamon.HassModel/Entities/Interfaces/IServiceTarget.cs
Outdated
Show resolved
Hide resolved
|
I've removed all methods from the interface to simplify the PR. To have empty interfaces is enough to fulfill needs of my request. |
|
btw should I squash all commits? |
|
You can, but eventually we will squash commit the whole PR anyway. Keeping then separate at first makes reviewing changes easier |
c172e53 to
a238833
Compare
9d8d3a9 to
5eeef5f
Compare
d939c41 to
6256634
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #897 +/- ##
==========================================
+ Coverage 79.80% 79.98% +0.17%
==========================================
Files 174 174
Lines 3407 3437 +30
Branches 436 440 +4
==========================================
+ Hits 2719 2749 +30
Misses 502 502
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
helto4real
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small stuff to fix before merge if you want to. I approve and let me know when it is ready for merge.
src/HassModel/NetDaemon.HassModel.CodeGenerator/NetDaemon.HassModel.CodeGenerator.csproj
Show resolved
Hide resolved
| yield return AttributeTypeGenerator.GenerateAttributeRecord(domainMetadata); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ther should be one line between functions.
| namespace Debug.apps.HassModel.MyInterfaceAutomation; | ||
|
|
||
| [NetDaemonApp] | ||
| [Focus] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove Focus attribute before merge
|
I got the answer from Frank regarding the docs removal. Rest is not important to fix. Merging |
Proposed change
Add base interfaces for generated Entities.
Type of change
Additional information
This functionality is discussed in Discord thread
Entity interfaces in NetDaemonChecklist
If user exposed functionality or configuration variables are added/changed: