Skip to content

Conversation

@helto4real
Copy link
Collaborator

Breaking change

Proposed change

This PR includes default metadata for light domain so we can get default values for attributes like Brightness even if the lights are off when generating the first time. This PR also deprecates the usage of UseAttributeBaseClasses setting since this chage makes it obsolete and much easier to include additional default metadata for other domains in the future.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 86.66% and project coverage change: +0.42% 🎉

Comparison is base (a89c03e) 80.74% compared to head (7ab6d5b) 81.17%.

❗ Current head 7ab6d5b differs from pull request most recent head ad7d261. Consider uploading reports for the commit ad7d261 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #901      +/-   ##
==========================================
+ Coverage   80.74%   81.17%   +0.42%     
==========================================
  Files         173      173              
  Lines        4326     4339      +13     
  Branches      435      435              
==========================================
+ Hits         3493     3522      +29     
+ Misses        653      633      -20     
- Partials      180      184       +4     
Flag Coverage Δ
unittests 81.17% <86.66%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...el/NetDaemon.HassModel.CodeGenerator/Controller.cs 36.23% <77.77%> (+36.23%) ⬆️
...or/MetaData/EntityMetaData/EntityMetaDataMerger.cs 97.91% <100.00%> (+0.13%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@helto4real helto4real enabled auto-merge (squash) August 5, 2023 12:03
@helto4real helto4real merged commit 6bea7d4 into dev Aug 5, 2023
@helto4real helto4real deleted the generate-default-metainfo branch August 5, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants