Skip to content

Conversation

@helto4real
Copy link
Collaborator

@helto4real helto4real commented Aug 7, 2023

Breaking change

Proposed change

This PR adds current tool version for code generator. This will help to track down code generation problems due to old versions of the code generator.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 30.00% and project coverage change: -0.13% ⚠️

Comparison is base (6fc1af2) 81.29% compared to head (8097e19) 81.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #904      +/-   ##
==========================================
- Coverage   81.29%   81.17%   -0.13%     
==========================================
  Files         173      174       +1     
  Lines        4342     4350       +8     
  Branches      435      435              
==========================================
+ Hits         3530     3531       +1     
- Misses        629      636       +7     
  Partials      183      183              
Flag Coverage Δ
unittests 81.17% <30.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...Model/NetDaemon.HassModel.CodeGenerator/Program.cs 0.00% <0.00%> (ø)
...n.HassModel.CodeGenerator/Helpers/VersionHelper.cs 25.00% <25.00%> (ø)
...assModel.CodeGenerator/CodeGeneration/Generator.cs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@helto4real helto4real force-pushed the version-info-on-codegen branch from df1a70a to 419a381 Compare August 7, 2023 07:14
@helto4real
Copy link
Collaborator Author

I did not add tests for this simple change. I did not think it would ever be potentially breaking anything.

@helto4real helto4real merged commit 8382bd0 into dev Aug 7, 2023
@helto4real helto4real deleted the version-info-on-codegen branch August 7, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants