Skip to content

Conversation

@svrooij
Copy link
Contributor

@svrooij svrooij commented Aug 9, 2023

Documentation for all projects, fixed #905

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add some suppression the CI so we do not fail until we documented all stuff. Maybe -nowarn flag could help?

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.08% ⚠️

Comparison is base (c80f953) 80.85% compared to head (f7af79a) 79.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #908      +/-   ##
==========================================
- Coverage   80.85%   79.77%   -1.08%     
==========================================
  Files         174      174              
  Lines        4361     3407     -954     
  Branches      437      436       -1     
==========================================
- Hits         3526     2718     -808     
+ Misses        651      503     -148     
- Partials      184      186       +2     
Flag Coverage Δ
unittests 79.77% <ø> (-1.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...el/Common/Extensions/ServiceCollectionExtension.cs 91.66% <ø> (-2.24%) ⬇️
...mon.HassClient/Internal/HomeAssistantConnection.cs 87.50% <ø> (ø)
...erator/CodeGeneration/ExtensionMethodsGenerator.cs 98.03% <ø> (-0.50%) ⬇️
...e/NetDaemon.Runtime/Internal/EntityMapperHelper.cs 85.71% <ø> (-2.75%) ⬇️

... and 125 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svrooij
Copy link
Contributor Author

svrooij commented Aug 9, 2023

Coverage dropped because the old way did not merge all the coverage files. It missed NetDaemon.Runtime.Tests

@svrooij svrooij force-pushed the feature/nuget-docs branch from c18e329 to 75777ff Compare August 9, 2023 09:01
Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good... I really (not) looking forward to the fixes of code xml docs hehe.

@helto4real helto4real merged commit 70e4472 into net-daemon:dev Aug 9, 2023
@svrooij svrooij deleted the feature/nuget-docs branch August 11, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Output documentation in nuget

2 participants