Skip to content

Conversation

@FrankBakkerNl
Copy link
Contributor

Breaking change

Made some types internal that were not intended to be public

  • CollectibleAssemblyLoadContext
  • YamlConfigurationSource
  • IRuntime

Proposed change

Add missing xml comments to public API's

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

<description>A .net core client for Home Assistant</description>
<projectUrl>https://github.com/helto4real/net-hassclient</projectUrl>
<description>Runtime</description>
<projectUrl>https://github.com/net-daemon/netdaemon</projectUrl>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe this must been slipping through from old code :). Good find :)

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06% ⚠️

Comparison is base (5ff1741) 79.95% compared to head (4067287) 79.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #913      +/-   ##
==========================================
- Coverage   79.95%   79.89%   -0.06%     
==========================================
  Files         174      174              
  Lines        3437     3437              
  Branches      440      440              
==========================================
- Hits         2748     2746       -2     
- Misses        503      504       +1     
- Partials      186      187       +1     
Flag Coverage Δ
unittests 79.89% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...odel/Common/Attributes/JetBrainsCodeAnnotations.cs 0.00% <ø> (ø)
...roviders/DynamicallyCompiledAppAssemblyProvider.cs 64.28% <ø> (ø)
...el/Internal/Config/Yaml/YamlConfigurationSource.cs 50.00% <ø> (ø)
...Runtime/Common/Extensions/HostBuilderExtensions.cs 41.66% <ø> (ø)
...time/Common/Extensions/ServiceBuilderExtensions.cs 100.00% <ø> (ø)
...e/Common/Extensions/ServiceCollectionExtensions.cs 0.00% <ø> (ø)
...nternal/Compiler/CollectableAssemblyLoadContext.cs 100.00% <100.00%> (ø)
...l/NetDaemon.AppModel/Internal/Compiler/Compiler.cs 98.46% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@helto4real helto4real enabled auto-merge (squash) August 20, 2023 19:47
@helto4real helto4real merged commit 9db4b38 into net-daemon:dev Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants