Skip to content

Fixes to CSS and scripts not loading properly#798

Merged
jokob-sk merged 2 commits intonetalertx:mainfrom
ingoratsdorf:contrib
Sep 22, 2024
Merged

Fixes to CSS and scripts not loading properly#798
jokob-sk merged 2 commits intonetalertx:mainfrom
ingoratsdorf:contrib

Conversation

@ingoratsdorf
Copy link
Contributor

DEFER in footer for ui_components breaks device details page
Typo in CSS in device details

Removed DEFER from ui_components as the device details page would not populate any more and the browser console would throw errors re function not found
@jokob-sk
Copy link
Collaborator

thank you @ingoratsdorf 🙏

@jokob-sk jokob-sk merged commit 10df736 into netalertx:main Sep 22, 2024

<!-- NetAlertX -->
<script src="js/handle_version.js"></script>
<script defer src="js/ui_components.js?v=<?php include 'php/templates/version.php'; ?>"></script>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - I had to reinsert the defer statement because the devices listing page wouldn't load at all - happy to investigate the detail page further, but for now I had to roll back this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. For me, with the 'defer' the details page loads but all fields are empty.
If I delete the 'defer', the page loads with all details.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that it's caused by the values in the fields? I'm running a clean installation in parallel and the details page loads fine. If recommend checking the dev console of the browser.

@ingoratsdorf
Copy link
Contributor Author

I cannot recall the exact message in the bowser console but something along the lines of "call of undefined updateIconPreview()".
Which is in ui_compoents.js.

@jokob-sk
Copy link
Collaborator

Thanks for that! I think I fixed that error in the dev image. I modified the updateIconPreview function quite a bit in the last few commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants