Add Data Plane Policing Policy module #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M: aci-endpoint-group M: aci-l3out-interface-profile M: aci_access_policies.tf M: aci_tenants.tf M: defaults.yaml M: modules.yaml
Contributor
Author
juchowan
requested changes
Apr 4, 2025
Contributor
juchowan
left a comment
juchowan
left a comment
There was a problem hiding this comment.
Hi @therealdoug, thanks for contribution! It took a while to review pending PRs, an we require some changes here. Would you still like to work on this PR?
defaults/defaults.yaml
Outdated
| mode: bit | ||
| sharing_mode: dedicated | ||
| rate: 0 | ||
| pir: 0 |
Contributor
There was a problem hiding this comment.
same in tenant policies for pir and pir_unit
modules/terraform-aci-access-leaf-interface-policy-group/main.tf
Outdated
Show resolved
Hide resolved
modules/terraform-aci-access-leaf-interface-policy-group/main.tf
Outdated
Show resolved
Hide resolved
modules/terraform-aci-data-plane-policing-policy/.terraform-docs.yml
Outdated
Show resolved
Hide resolved
modules/terraform-aci-data-plane-policing-policy/.terraform-docs.yml
Outdated
Show resolved
Hide resolved
- update `pir` to `peak_rate` - update `pir_unit` to `peak_rate_unit` - Add count - Add policy checks - Pre-commit checks ran
Contributor
Author
|
Thanks for the feedback! Update submitted for requested changes. |
juchowan
requested changes
Apr 8, 2025
- Fix naming after greedy search and replace - Add Tenant policy location for DPP - Run pre-commit
juchowan
approved these changes
Apr 29, 2025
ogorczow
force-pushed
the
data-plane-policing
branch
from
6ddb726 to
eb64caf
Compare
…terraform-aci-nac-aci into therealdoug-data-plane-policing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A: aci-data-plane-policing-policy
M: aci-access-leaf-interface-policy-group
M: aci-endpoint-group
M: aci-l3out-interface-profile
M: aci_access_policies.tf
M: aci_tenants.tf
M: defaults.yaml
M: modules.yaml