Skip to content

bug: bottom dialog fragment attached not attached to activity #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doromaraujo merged 3 commits into from
Dec 1, 2025
Merged

bug: bottom dialog fragment attached not attached to activity #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b66b6ed
Remove onClickListener from peersBtn
doromaraujo Dec 1, 2025
e2d588d
Remove unused imports
doromaraujo Dec 1, 2025
3f1a64e
Check if BottomDialogFragment is attached to Activity
doromaraujo Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/src/main/java/io/netbird/client/ui/home/BottomDialogFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ public Dialog onCreateDialog(Bundle savedInstanceState) {
// Apply transparent background theme to the dialog
BottomSheetDialog dialog = new BottomSheetDialog(requireContext(), R.style.BottomSheetDialogTheme);
dialog.setOnShowListener(dialogInterface -> {
// Check if the fragment is still attached to avoid IllegalStateException
if (getActivity() == null || !isAdded()) {
return;
}

FrameLayout bottomSheet = dialog.findViewById(com.google.android.material.R.id.design_bottom_sheet);
if (bottomSheet != null) {
// Set the bottom sheet to be full screen
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/java/io/netbird/client/ui/home/HomeFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import android.widget.TextView;

import androidx.annotation.NonNull;
import androidx.appcompat.app.AlertDialog;
import androidx.fragment.app.Fragment;

import com.airbnb.lottie.LottieAnimationView;
Expand All @@ -22,7 +21,6 @@
import io.netbird.client.StateListener;
import io.netbird.client.StateListenerRegistry;
import io.netbird.client.databinding.FragmentHomeBinding;
import io.netbird.client.ui.PreferenceUI;
import io.netbird.gomobile.android.PeerInfo;
import io.netbird.gomobile.android.PeerInfoArray;

Expand Down Expand Up @@ -126,6 +124,8 @@ public void onDestroyView() {
super.onDestroyView();
buttonAnimation.destroy();
stateListenerRegistry.unregisterServiceStateListener(this);
FrameLayout openPanelCardView = binding.peersBtn;
openPanelCardView.setOnClickListener(null);
binding = null;
}

Expand Down
Loading