-
Notifications
You must be signed in to change notification settings - Fork 41
Bump client version #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump client version #120
Conversation
WalkthroughThe netbird submodule pointer is updated from commit d2e48d4f5e3d to commit 031ab1117800, reflecting version advancement with no functional code changes in the consuming repository. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
netbird(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-debug
- GitHub Check: Analyze (java-kotlin)
| @@ -1 +1 @@ | |||
| Subproject commit d2e48d4f5e3dba008393b3cee233ed9877ee1f9a | |||
| Subproject commit 031ab1117800fec893f4c433cbd1c3999882e6b4 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify the netbird submodule commit hash
cd netbird 2>/dev/null && git log -1 031ab1117800fec893f4c433cbd1c3999882e6b4 --oneline || echo "SUBMODULE_NOT_INITIALIZED_OR_COMMIT_NOT_FOUND"Repository: netbirdio/android-client
Length of output: 302
🏁 Script executed:
#!/bin/bash
# Check .gitmodules to see the netbird submodule configuration
cat .gitmodules 2>/dev/null | grep -A 3 "netbird" || echo "No .gitmodules found or netbird not listed"
# Also check if there's a netbird directory
ls -la netbird 2>/dev/null || echo "No netbird directory"Repository: netbirdio/android-client
Length of output: 262
The submodule commit hash is invalid and does not exist in the upstream netbird repository.
The commit 031ab1117800fec893f4c433cbd1c3999882e6b4 cannot be found in https://github.com/netbirdio/netbird.git (error: "not our ref"). This will prevent the submodule from being properly initialized or cloned. Verify that the correct commit hash has been used and update the submodule pointer to a valid commit that exists in the upstream repository.
🤖 Prompt for AI Agents
In netbird around lines 1-1, the submodule commit SHA recorded
(031ab1117800fec893f4c433cbd1c3999882e6b4) does not exist in the upstream repo;
update the submodule pointer to a valid commit by fetching the upstream and
selecting an existing commit or tag (e.g., git -C netbird fetch origin && git -C
netbird tag --list or git -C netbird log --oneline to pick a SHA), then update
the superproject to point to that SHA (checkout the valid SHA inside netbird,
git add netbird, git commit -m "Update netbird submodule to <valid-SHA>") or set
the submodule to a branch (git submodule set-branch --branch main netbird && git
submodule update --remote netbird && git add .gitmodules netbird && git commit)
and push the change so the submodule can be initialized/cloned successfully.
Bump client version to latest
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.