Skip to content

Remove dns0eu#508

Merged
heisbrot merged 1 commit intomainfrom
fix/remove-dns0eu
Nov 10, 2025
Merged

Remove dns0eu#508
heisbrot merged 1 commit intomainfrom
fix/remove-dns0eu

Conversation

@heisbrot
Copy link
Copy Markdown
Contributor

@heisbrot heisbrot commented Nov 10, 2025

Summary by CodeRabbit

  • Changes
    • Removed DNS0 and DNS0Zero nameserver preset options from the selection interface
    • Updated DNS preset modal layout with optimized width and single-column grid design on medium screens

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Nov 10, 2025

Walkthrough

Two DNS presets (DNS0 and DNS0Zero) are removed from the NameserverPresets export and corresponding UI blocks in the modal component. Modal layout is also adjusted, reducing max width and simplifying grid columns on medium screens.

Changes

Cohort / File(s) Summary
DNS Preset Removal
src/interfaces/Nameserver.ts, src/modules/dns-nameservers/NameserverTemplateModal.tsx
Removed DNS0 and DNS0Zero preset definitions and their associated UI references from both the preset registry and modal presentation layer.
Layout Adjustments
src/modules/dns-nameservers/NameserverTemplateModal.tsx
Reduced modal max-width from max-w-5xl to max-w-xl and simplified grid layout from two columns to single column on medium screens.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Straightforward data removal (preset entries) across two files
  • Layout adjustments are CSS class changes with minimal logic impact
  • Removals are non-breaking and self-contained; verify no dependent code references the deleted presets elsewhere in the codebase

Poem

🐰 Two presets gone, the modal shrinks and sighs,
DNS0 and friends say their goodbyes,
Single columns now, a cleaner view,
Less to choose from, but fresh and new! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove dns0eu' accurately describes the main change: removal of DNS0 and DNS0.EU Zero DNS presets from both the Nameserver interface and the NameserverTemplateModal component.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/remove-dns0eu

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/modules/dns-nameservers/NameserverTemplateModal.tsx (1)

69-69: Remove redundant responsive class.

The md:grid-cols-1 class is redundant since grid-cols-1 already applies to all screen sizes including medium and above (Tailwind uses mobile-first approach).

Apply this diff to simplify:

-        <div className={"grid grid-cols-1 md:grid-cols-1 gap-4"}>
+        <div className={"grid grid-cols-1 gap-4"}>
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e2219ae and c058ed1.

⛔ Files ignored due to path filters (2)
  • src/assets/nameservers/dns0-zero.svg is excluded by !**/*.svg
  • src/assets/nameservers/dns0.svg is excluded by !**/*.svg
📒 Files selected for processing (2)
  • src/interfaces/Nameserver.ts (0 hunks)
  • src/modules/dns-nameservers/NameserverTemplateModal.tsx (1 hunks)
💤 Files with no reviewable changes (1)
  • src/interfaces/Nameserver.ts
🔇 Additional comments (1)
src/modules/dns-nameservers/NameserverTemplateModal.tsx (1)

67-67: LGTM! Modal width appropriately adjusted.

The reduction from max-w-5xl to max-w-xl is appropriate given the removal of two DNS presets.

@heisbrot heisbrot linked an issue Nov 10, 2025 that may be closed by this pull request
@heisbrot heisbrot merged commit a632eee into main Nov 10, 2025
4 checks passed
@heisbrot heisbrot deleted the fix/remove-dns0eu branch November 10, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DNS0 stopped operating

2 participants