Preserve query params for ssh and rdp

[heisbrot]

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Fixed query parameter preservation for SSH and RDP peer connections to maintain connection settings during authentication flows.
  • Improved authentication-based session cleanup to prevent unnecessary clearing of connection parameters for specific paths.
  • Enhanced authentication state handling for more reliable session management.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

📝 Walkthrough

Walkthrough

The SecureProvider component now selectively preserves query parameters for specific SSH and RDP peer paths instead of globally removing them on authentication. The authentication cleanup logic becomes more granular, checking path restrictions before clearing stored query parameters, and the useEffect dependency array expands to monitor path changes.

Changes

Cohort / File(s)	Summary
Query Parameter Preservation src/auth/SecureProvider.tsx	Introduces PRESERVE_QUERY_PARAMS_PATHS constant for SSH/RDP paths, restricts localStorage.removeItem() to authenticated states while excluding preserved paths, adds explicit else if (!isAuthenticated) branching, and includes currentPath in useEffect dependencies for path-change detection.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Query params we now protect,
For SSH and RDP, we show respect,
Paths preserved in logic's light,
Dependencies dance—auth and site!
🔐✨

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'Preserve query params for ssh and rdp' directly and concisely describes the main change: introducing logic to preserve query parameters for specific SSH and RDP paths.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into main

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/ssh-rdp-query

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}